Skip to content

Merge pull request #20 from Overcastan/andrew-update-winterfell #76

Merge pull request #20 from Overcastan/andrew-update-winterfell

Merge pull request #20 from Overcastan/andrew-update-winterfell #76

Triggered via push February 14, 2024 15:22
Status Success
Total duration 2m 15s
Artifacts

ci.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

40 warnings
Dependency Security Audit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Dependency Security Audit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Dependency Security Audit
2 warnings found!
Dependency Security Audit
Unknown warning kind unsound found, please, file a bug
Dependency Security Audit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Dependency Security Audit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Dependency Security Audit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Dependency Security Audit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified: src/stark.rs#L57
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> src/stark.rs:57:5 | 57 | async fn prove( | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 57 ~ fn prove( 58 | &self, 59 | options: ProofOptions, 60 | witness: Self::Witness, 61 ~ ) -> impl std::future::Future<Output = Result<Proof<Self>, ProvingError>> + Send {async { 62 | default_prove(self, options, witness) 63 ~ } } |
item in documentation is missing backticks: src/prover.rs#L183
warning: item in documentation is missing backticks --> src/prover.rs:183:28 | 183 | /// Bit reverses the first ce_domain_size many values of the matrix columns. | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown note: the lint level is defined here --> src/lib.rs:1:22 | 1 | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]` help: try | 183 | /// Bit reverses the first `ce_domain_size` many values of the matrix columns. | ~~~~~~~~~~~~~~~~
unreachable pattern: src/eval_cpu.rs#L70
warning: unreachable pattern --> src/eval_cpu.rs:70:9 | 70 | _ => unreachable!(), | ^ | = note: `#[warn(unreachable_patterns)]` on by default
the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable: src/lib.rs#L28
warning: the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable --> src/lib.rs:28:5 | 28 | return_position_impl_trait_in_trait, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable: src/lib.rs#L23
warning: the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable --> src/lib.rs:23:5 | 23 | async_fn_in_trait, | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: examples/rescue/rescue.rs#L293
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> examples/rescue/rescue.rs:293:50 | 293 | fn matrix_mul<F: PrimeField>(a: &Vec<Vec<F>>, b: &Vec<Vec<F>>) -> Vec<Vec<F>> { | ^^^^^^^^^^^^ help: change this to: `&[Vec<F>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: examples/rescue/rescue.rs#L293
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> examples/rescue/rescue.rs:293:33 | 293 | fn matrix_mul<F: PrimeField>(a: &Vec<Vec<F>>, b: &Vec<Vec<F>>) -> Vec<Vec<F>> { | ^^^^^^^^^^^^ help: change this to: `&[Vec<F>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: examples/rescue/rescue.rs#L272
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> examples/rescue/rescue.rs:272:44 | 272 | fn transpose<T: Clone + Copy + Default>(m: &Vec<Vec<T>>) -> Vec<Vec<T>> { | ^^^^^^^^^^^^ help: change this to: `&[Vec<T>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: examples/rescue/rescue.rs#L219
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> examples/rescue/rescue.rs:219:30 | 219 | fn echelon_form<T: Field>(m: &Vec<Vec<T>>) -> Vec<Vec<T>> { | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default help: change this to | 219 ~ fn echelon_form<T: Field>(m: &[Vec<T>]) -> Vec<Vec<T>> { 220 | if m.is_empty() || m[0].is_empty() { ... 227 | let mut lead = 0; 228 ~ let mut m = m.to_owned(); |
use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified: src/stark.rs#L57
warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified --> src/stark.rs:57:5 | 57 | async fn prove( | ^^^^^ | = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` = note: `#[warn(async_fn_in_trait)]` on by default help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change | 57 ~ fn prove( 58 | &self, 59 | options: ProofOptions, 60 | witness: Self::Witness, 61 ~ ) -> impl std::future::Future<Output = Result<Proof<Self>, ProvingError>> + Send {async { 62 | default_prove(self, options, witness) 63 ~ } } |
item in documentation is missing backticks: src/prover.rs#L183
warning: item in documentation is missing backticks --> src/prover.rs:183:28 | 183 | /// Bit reverses the first ce_domain_size many values of the matrix columns. | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown note: the lint level is defined here --> src/lib.rs:1:22 | 1 | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]` help: try | 183 | /// Bit reverses the first `ce_domain_size` many values of the matrix columns. | ~~~~~~~~~~~~~~~~
unreachable pattern: src/eval_cpu.rs#L70
warning: unreachable pattern --> src/eval_cpu.rs:70:9 | 70 | _ => unreachable!(), | ^ | = note: `#[warn(unreachable_patterns)]` on by default
the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable: src/lib.rs#L28
warning: the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable --> src/lib.rs:28:5 | 28 | return_position_impl_trait_in_trait, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable: src/lib.rs#L23
warning: the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable --> src/lib.rs:23:5 | 23 | async_fn_in_trait, | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, Swatinem/rust-cache@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/