Allow SDKAlias to use nested objects for physical id and return values #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements
In
SDKAlias
function, if object returned from API is more than 1 level deep, it was not possible to get nested object properties. Concrete example that I needed this functionality for is writing custom resource for creating AmazonCognito User Pool Client, where response data is nested underUserPoolClient
map. (Example below)This pull request allows pulling physicalResourceId and query-able properties with Fn::GetAtt by using dot notation to select nested object properties from SDK call result.
Updated aws-sdk version
Essentially, feature above is being tested with custom resource for Amazon Cognito User Pool Client management. Without bumping up the aws-sdk version, I would get parameter validation errors
Fix
In SDKAlias section, README shows
returnKeys
as option key to define which API response fields should be mapped to data accessible withFn::GetAtt
cfn function. However, looking at the source code itself, seems likereturnAttrs
is actual key being used. README has been updated to reflect reality of the source code