fix: TypeError on function f() { return; }

Fixes JamieMason#38. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk · Jun 7, 2024 · fd2fadd · fd2fadd
1 parent a34f8f9
commit fd2fadd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/prefer-arrow-functions.spec.ts b/src/prefer-arrow-functions.spec.ts
@@ -500,6 +500,10 @@ const invalidAndHasBlockStatement = [
     code: 'async function foo(a) { console.log(3); }',
     output: 'const foo = async (a) => { console.log(3); };',
   },
+  {
+    code: 'function foo() { return; }',
+    output: 'const foo = () => { return; };',
+  },
 
   // https://github.com/JamieMason/eslint-plugin-prefer-arrow-functions/issues/28
   {

diff --git a/src/prefer-arrow-functions.ts b/src/prefer-arrow-functions.ts
@@ -49,7 +49,8 @@ export default {
       return (
         node.body.body &&
         node.body.body.length === 1 &&
-        node.body.body[0].type === 'ReturnStatement'
+        node.body.body[0].type === 'ReturnStatement' &&
+        node.body.body[0].argument !== null
       );
     };