Sourcery Starbot ⭐ refactored ancker010/exabgp-flowspec-generator #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcery-ai-bot
commented
Jun 14, 2020
Comment on lines
-17
to
+20
| subnet = IPv4Network("192.168.0.0/16") | ||
| subnet = IPv4Network("192.168.0.0/16") | ||
| bits = getrandbits(subnet.max_prefixlen - subnet.prefixlen) | ||
| addr = IPv4Address(subnet.network_address + bits) | ||
| addr_str = str(addr) | ||
| return addr_str | ||
| return str(addr) |
There was a problem hiding this comment.
Function genipv4 refactored with the following changes:
- Inline variable that is only used once
Comment on lines
-27
to
+26
| addr_str6 = str(addr6) | ||
| return addr_str6 | ||
| return str(addr6) |
There was a problem hiding this comment.
Function genipv6 refactored with the following changes:
- Inline variable that is only used once
Comment on lines
-33
to
+36
| flow_types = [] | ||
| flow_types.append( | ||
| "announce flow route { match { source " + genipv4() + "/32; destination 192.168.255.10/32; destination-port =" + str(random.randint(1024, 65530)) + "; protocol tcp; } then { rate-limit " + str(random.randint(9600, 51200)) + "; } }") | ||
| flow_types = [ | ||
| "announce flow route { match { source " + genipv4() + | ||
| "/32; destination 192.168.255.10/32; destination-port =" + str( | ||
| random.randint(1024, 65530)) + "; protocol tcp; } then { rate-limit " + | ||
| str(random.randint(9600, 51200)) + "; } }" | ||
| ] |
There was a problem hiding this comment.
Function genflows refactored with the following changes:
- Merge append into list assignment
Comment on lines
-48
to
+54
| flow_types6 = [] | ||
| flow_types6.append( | ||
| "announce flow route { match { source " + genipv6() + "/128; destination 2001:DB8:beef:cafe::1/128; destination-port =" + str(random.randint(1024, 65530)) + "; protocol tcp; } then { rate-limit " + str(random.randint(9600, 51200)) + "; } }") | ||
| flow_types6 = [ | ||
| "announce flow route { match { source " + genipv6() + | ||
| "/128; destination 2001:DB8:beef:cafe::1/128; destination-port =" + str( | ||
| random.randint(1024, 65530)) + "; protocol tcp; } then { rate-limit " + | ||
| str(random.randint(9600, 51200)) + "; } }" | ||
| ] |
There was a problem hiding this comment.
Function genflows6 refactored with the following changes:
- Merge append into list assignment
Comment on lines
-66
to
+74
| for x in range(0, count): | ||
| for _ in range(count): | ||
| flows = genflows() | ||
| messages.append(random.choice(flows)) | ||
|
|
||
| for x in range(0, count): | ||
| for x in range(count): |
There was a problem hiding this comment.
Lines 66-70 refactored with the following changes:
- Replace range(0, x) with range(x)
- Replace unused for index with underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: