Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use GITHUB_OUTPUT envvar instead of set-output command #503

Closed
wants to merge 2 commits into from
Closed

ci: Use GITHUB_OUTPUT envvar instead of set-output command #503

wants to merge 2 commits into from

Conversation

arunsathiya
Copy link

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of set-output to $GITHUB_OUTPUT

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

@arunsathiya arunsathiya requested a review from a team as a code owner January 12, 2024 01:03
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the update!

@Golodhros
Copy link
Member

Please check the DCO task @arunsathiya

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale stalebot believes this issue/PR is no longer active label Mar 13, 2024
Signed-off-by: Arun <arun@arun.blog>
@arunsathiya
Copy link
Author

Sorry for the delay here, @Golodhros. It should be okay now!

@kristenarmes
Copy link

hi @arunsathiya, thanks for the change. I just realized this is one of the deprecated repos that isn't being maintained or taking new PRs, since all the projects transitioned a while back to a monorepo. If you'd like this change made, pls make a new PR here https://github.com/amundsen-io/amundsen

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one.

@stale stale bot closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR is no longer active
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants