Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Flip incorrect percentages in error-reporting.js #40048

Merged
merged 1 commit into from
Jun 7, 2024
Merged

🐛 Flip incorrect percentages in error-reporting.js #40048

merged 1 commit into from
Jun 7, 2024

Conversation

danielrozenberg
Copy link
Member

No description provided.

erwinmombay
erwinmombay requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@erwinmombay erwinmombay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking for review

@erwinmombay
Copy link
Member

went thru the logic changes (even on the old PR's) with @danielrozenberg to be more thorough. This change should be the correct change

@danielrozenberg danielrozenberg merged commit bba1b5c into ampproject:main Jun 7, 2024
52 checks passed
@danielrozenberg danielrozenberg deleted the error-reporting-flip-percentages branch June 7, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielrozenberg @erwinmombay @ampprojectbot