🏗 Partial updates for core devDependencies #39768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
core-devdep-partial-r
branch
2 times, most recently
from
b479b1d
to
098ffb4
Compare
erwinmombay
approved these changes
Jan 25, 2024
danielrozenberg
force-pushed
the
core-devdep-partial-r
branch
from
098ffb4
to
e2ab76a
Compare
danielrozenberg
force-pushed
the
core-devdep-partial-r
branch
from
e2ab76a
to
bc11c77
Compare
|
@erwinmombay requires re-approval because I had to force-push a new commit to fix a merge conflict, and the bundle-size change requires approval on the last commit :) |
I decided to figure out why the bundle size increased so much, looks like there's a bug in |
|
Looks like even 5.16.2 causes bundle size changes, so reverting the change to |
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
* Partial updates for core devDependencies * Reduce `terser` back to last-known version that doesn't increase the bundle size * Reduce `terser` back to current version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating all of the devDependencies together is hard. Splitting this to make it easier.
This PR updates the dependencies starting with
rthroughz, excluding:tempy,typescript, andsinonwhich requires non-trivial manual changes to updatereact*, as this package is updated by a separate renovate jobNOTE: this PR causes non-trivial bundle-size increases!