Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #864: Support <amp-carousel> in 'Gallery' widget. #917

Merged
merged 5 commits into from
Jan 30, 2018
Merged

Issue #864: Support <amp-carousel> in 'Gallery' widget. #917

merged 5 commits into from
Jan 30, 2018

Commits on Jan 30, 2018

  1. Issue #864: Support <amp-carousel> in 'Gallery' widget. 

    There's an existing handler to create 'amp-carousel' elements:
class AMP_Gallery_Embed_Handler.
So override the 'Gallery' widget class.
And use that in render_media().
Otherwise, that function is copied from the parent.
The parent calls gallery_shortcode() at the end of render_media().
And that function doesn't have a filter for the markup.
    Ryan Kienstra committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e98cb09 View commit details
    Browse the repository at this point in the history

  2. Issue #864: Accomodate WP versions < 4.9, without the 'Gallery' widget. 

    Don't subclass the widget if it doesn't exist.
And don't test the subclass if it's not present.
    Ryan Kienstra committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a8b4bf9 View commit details
    Browse the repository at this point in the history

  3. Issue #864: Move the markTestSkipped() higher in the function. 

    Before, there was an error,
As it instantiated AMP_Widget_Media_Gallery if it didn't exist.
    Ryan Kienstra committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a2bd726 View commit details
    Browse the repository at this point in the history

  4. Use do_shortcode() instead of calling gallery embed logic directly

    @westonruter
    westonruter committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    2aa7ba2 View commit details
    Browse the repository at this point in the history

  5. Add links to images in gallery when requested

    @westonruter
    westonruter committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    d6cccd2 View commit details
    Browse the repository at this point in the history