Fix post preview in Reader mode #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierlon
approved these changes
May 7, 2020
|
Works for me |
…preview-reader-mode * 'develop' of github.com:ampproject/amp-wp: Enable SSR by default, remove use of WP_DEBUG as a signal. (#4669) Update dependency @wordpress/babel-preset-default to v4.12.1 (#4494) Revert "Move .gitattributes file into lib/optimizer folder" Move .gitattributes file into lib/optimizer folder Remove redundant JSONOBJECT_AS_ARRAY constant Use substr() instead of a replacement for removing the leading comment Add git attributes file to mark certain file as being generated Remove unused import Complete stubbed requests data Add more tests to assert runtime transformer behavior Remove runtime style tag if stylesheet is linked Nake use of styles provided via config if available Add STYLES configuration key to AmpRuntimeCss transformer Adapt spec test to extract configuration arguments from input files Update spec files Add puppeteer as a peer dependency Update dependency @wordpress/block-editor to v3.10.0 Update dependency xwp/wp-dev-lib to v1.6.3
|
I found something that was missed: previewing changes to the title. I've addressed this in 7d81390. Please review. |
pierlon
approved these changes
May 7, 2020
westonruter
added a commit
that referenced
this pull request
May 8, 2020
* Fix post preview in Reader mode * Use post object so that title (and excerpt) can be previewed
westonruter
added a commit
that referenced
this pull request
May 13, 2020
…/reader-mode-themes * 'develop' of github.com:ampproject/amp-wp: (59 commits) Strip multiple BOM characters (#4683) Strip leading BOM and whitespace and trailing HTML comment before parsing validation response JSON (#4679) Update dependency xwp/wp-dev-lib to v1.6.4 Update dependency eslint to v7 Remove unused RuntimeException Use explicit string type instead of generic array in return Avoid method map and replace with a switch Defer removal of attributes until after layout application Fix post preview in Reader mode (#4665) Ensure that source map comment is preserved at the end of amp-custom.css Pass DOMAttr instances rather than attribute name and value as separate args Enable SSR by default, remove use of WP_DEBUG as a signal. (#4669) Use padding-top and override regular inline style for heights Update php-parallel-lint dependency to new name Use :first-child to reference sizer in CSS Update dependency @wordpress/babel-preset-default to v4.12.1 (#4494) Fix error type for bad sizes test Provide more precise error for thrown exception Test precise error messages Fix attribute name in error messages ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4656
Supersedes #4663
This fixes a regression which was introduced in c74ba97 (as part of #3781) when moving to lazy-load properties of
AMP_Post_Template. As I recall, switching to load the post data with a getter when accessingpostwas to avoid keeping a copy of that post around necessarily, as that would introduce a possibility of the copy inAMP_Post_Templatebecoming out of sync with what is in the DB. Nevertheless, this broke the ability to preview changes to the queried object, which gets populated by thethe_previewfilter.This PR reverts part of c74ba97.
Checklist