Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt heights, sizes and media attributes for SSR #4482

Merged
merged 41 commits into from
May 8, 2020
Merged

Adapt heights, sizes and media attributes for SSR #4482

merged 41 commits into from
May 8, 2020

Commits on Mar 27, 2020

  1. Update test suite and local metadata fallback

    @schlessera
    schlessera committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c026485 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Add logic to SSR to convert sizes and heights attributes

    @schlessera
    schlessera committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    f248341 View commit details
    Browse the repository at this point in the history

  2. Add basic media attribute handling

    @schlessera
    schlessera committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    f1f5fb3 View commit details
    Browse the repository at this point in the history

  3. Exclude amp-audio from applying layout at the server

    @schlessera
    schlessera committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    272862e View commit details
    Browse the repository at this point in the history

  4. Add context info for media attribute

    @schlessera
    schlessera committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    6c589a5 View commit details
    Browse the repository at this point in the history

  5. Skip spec tests for newly supported attributes

    @schlessera
    schlessera committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    fa9d521 View commit details
    Browse the repository at this point in the history

  6. Fix PHPStan issue

    @schlessera
    schlessera committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    3b46da7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into add/4439-transform-media-sizes-heights

    @schlessera
    schlessera committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    8668a85 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Adapt tests for getElementId()

    @schlessera
    schlessera committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    f1102c6 View commit details
    Browse the repository at this point in the history

  2. Add another getElementId() test

    @schlessera
    schlessera committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    e04f9cf View commit details
    Browse the repository at this point in the history

  3. Adapt media query to use for replacing media attribute

    @schlessera
    schlessera committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    6efc85a View commit details
    Browse the repository at this point in the history

  4. Fix negated media syntax

    @schlessera
    schlessera committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    330fd94 View commit details
    Browse the repository at this point in the history

  5. Another stab at fixing media query generation

    @schlessera
    schlessera committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    e24422e View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Merge branch 'develop' into add/4439-transform-media-sizes-heights

    @schlessera
    schlessera committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    48bfebf View commit details
    Browse the repository at this point in the history

  2. Add size check for adding CSS

    @schlessera
    schlessera committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    dd9e71b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Merge branch 'develop' into add/4439-transform-media-sizes-heights

    @schlessera
    schlessera committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    5b514b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Just strip sizes when srcset is missing

    @schlessera
    schlessera committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    1891b37 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Use neutral formatting for CSS size number 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @schlessera @westonruter
    schlessera and westonruter committed May 5, 2020
    Configuration menu
    Copy the full SHA
    a666012 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into add/4439-transform-media-sizes-heights

    @schlessera
    schlessera committed May 5, 2020
    Configuration menu
    Copy the full SHA
    f5f99b4 View commit details
    Browse the repository at this point in the history

  3. Don't remove sizes when disable-inline-width is set

    @schlessera
    schlessera committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0b677f4 View commit details
    Browse the repository at this point in the history

  4. Remove trailing commas in method calls

    @schlessera
    schlessera committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b2172e6 View commit details
    Browse the repository at this point in the history

  5. Skip currently broken tests in Optimizer

    @schlessera
    schlessera committed May 5, 2020
    Configuration menu
    Copy the full SHA
    2d978c6 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Merge branch 'develop' into add/4439-transform-media-sizes-heights

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    4b2781a View commit details
    Browse the repository at this point in the history

  2. Remove test exception for #4654

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    9731fe3 View commit details
    Browse the repository at this point in the history

  3. Omit unneeded semicolons 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @schlessera @westonruter
    schlessera and westonruter committed May 7, 2020
    Configuration menu
    Copy the full SHA
    58b550f View commit details
    Browse the repository at this point in the history

  4. Remove left-over attribute removal 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @schlessera @westonruter
    schlessera and westonruter committed May 7, 2020
    Configuration menu
    Copy the full SHA
    4842fc8 View commit details
    Browse the repository at this point in the history

  5. Align equal sign

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    facc016 View commit details
    Browse the repository at this point in the history

  6. Adapt tests for removed semi-colons

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    bf6da0a View commit details
    Browse the repository at this point in the history

  7. Fix attribute name in error messages

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    11ff49c View commit details
    Browse the repository at this point in the history

  8. Test precise error messages

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    c470761 View commit details
    Browse the repository at this point in the history

  9. Provide more precise error for thrown exception

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    0906a39 View commit details
    Browse the repository at this point in the history

  10. Fix error type for bad sizes test

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    69f0b36 View commit details
    Browse the repository at this point in the history

  11. Use :first-child to reference sizer in CSS

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    2f423ca View commit details
    Browse the repository at this point in the history

  12. Update php-parallel-lint dependency to new name

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    f877435 View commit details
    Browse the repository at this point in the history

  13. Use padding-top and override regular inline style for heights

    @schlessera
    schlessera committed May 7, 2020
    Configuration menu
    Copy the full SHA
    f4d37fa View commit details
    Browse the repository at this point in the history

  14. Pass DOMAttr instances rather than attribute name and value as separa… 

    …te args
    @westonruter
    westonruter committed May 7, 2020
    Configuration menu
    Copy the full SHA
    a36dc0f View commit details
    Browse the repository at this point in the history

  15. Ensure that source map comment is preserved at the end of amp-custom.css

    @westonruter
    westonruter committed May 7, 2020
    Configuration menu
    Copy the full SHA
    84a4464 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Defer removal of attributes until after layout application

    @schlessera
    schlessera committed May 8, 2020
    Configuration menu
    Copy the full SHA
    8767882 View commit details
    Browse the repository at this point in the history

  2. Avoid method map and replace with a switch

    @schlessera
    schlessera committed May 8, 2020
    Configuration menu
    Copy the full SHA
    a7de3cd View commit details
    Browse the repository at this point in the history

  3. Use explicit string type instead of generic array in return

    @westonruter
    westonruter committed May 8, 2020
    Configuration menu
    Copy the full SHA
    3960f9c View commit details
    Browse the repository at this point in the history

  4. Remove unused RuntimeException

    @westonruter
    westonruter committed May 8, 2020
    Configuration menu
    Copy the full SHA
    5807091 View commit details
    Browse the repository at this point in the history