Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore test utils from code coverage #3782

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Ignore test utils from code coverage #3782

merged 1 commit into from
Nov 19, 2019

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Nov 16, 2019

Summary

Fixes #3583.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Nov 16, 2019
@pierlon
Copy link
Contributor Author

pierlon commented Nov 16, 2019

PHP files are also being included in the coverage. Should those be excluded also?

@westonruter
Copy link
Member

PHP files used for testing should also be excluded, I think.

@pierlon
Copy link
Contributor Author

pierlon commented Nov 18, 2019

My previous comment can be disregarded. Codecov shows both the code coverage for JS and PHP files together.

@westonruter westonruter added this to the v1.5 milestone Nov 19, 2019
westonruter
westonruter approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much (read: any) experience with Jest, but this looks good to me.

@westonruter westonruter merged commit c900d84 into develop Nov 19, 2019
@westonruter westonruter deleted the fix/ignore-test-utils branch November 19, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Ignore JS test utils from code coverage
3 participants
@pierlon @westonruter @googlebot