Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass entire Reader mode templates through post-processor #3781

Merged
merged 28 commits into from
Nov 20, 2019
Merged

Pass entire Reader mode templates through post-processor #3781

merged 28 commits into from
Nov 20, 2019

Commits on Nov 16, 2019

  1. Pass entire Reader mode templates through post-processor 

    Eliminate majority of Reader mode template's unique rendering path.
    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    6717e4f View commit details
    Browse the repository at this point in the history

  2. Fix tests in WP<5.2

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    0c34778 View commit details
    Browse the repository at this point in the history

  3. Transition away from AMP_Post_Template to traditional template tags

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    8070c56 View commit details
    Browse the repository at this point in the history

  4. Show 'View Comments' link if comments closed but comments are present

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    531d807 View commit details
    Browse the repository at this point in the history

  5. Fix passing featured image to Reader template

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    68c26e5 View commit details
    Browse the repository at this point in the history

  6. Prevent dev mode in Reader mode template

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    22c725b View commit details
    Browse the repository at this point in the history

  7. Fix AMP_Render_Post_Test (again) by setting up postdata

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    82cd73c View commit details
    Browse the repository at this point in the history

  8. Revert changes to meta-comments-link to preserve prior behavior

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    6da568c View commit details
    Browse the repository at this point in the history

  9. Ensure amp_post_template_data filter-supplied data takes precedence

    @westonruter
    westonruter committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    b1555eb View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. Restore use of post template data and getter

    @westonruter
    westonruter committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    aed6c0e View commit details
    Browse the repository at this point in the history

  2. fixup! Prevent dev mode in Reader mode template

    @westonruter
    westonruter committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    29abc85 View commit details
    Browse the repository at this point in the history

  3. Remove obsolete back-compat prior to WP<4.9

    @westonruter
    westonruter committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    a3cb92a View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Improve phpdoc comments including deprecated note 

    Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
    @westonruter @schlessera
    westonruter and schlessera committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    8da4f68 View commit details
    Browse the repository at this point in the history

  2. Eliminate bogus else condition

    @westonruter
    westonruter committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    93cede4 View commit details
    Browse the repository at this point in the history

  3. Use add_filter() instead of add_action(); add static keyword

    @westonruter
    westonruter committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    c9891b5 View commit details
    Browse the repository at this point in the history

  4. Fix phpdoc for amp_post_template_footer

    @westonruter
    westonruter committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    d536c8f View commit details
    Browse the repository at this point in the history

  5. Move to lazy gathering of AMP_Post_Template properties

    @westonruter
    westonruter committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    c74ba97 View commit details
    Browse the repository at this point in the history

  6. Remove unused private method merge_data_for_key; add phpdoc

    @westonruter
    westonruter committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    d9a3883 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Remove unused (and deprecated) functions amp_load_fasterimage_classes… 

    …() and amp_get_fasterimage_client()
    @westonruter
    westonruter committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    ca89bf9 View commit details
    Browse the repository at this point in the history

  2. Move deprecated functions to deprecated.php

    @westonruter
    westonruter committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    5b0ec96 View commit details
    Browse the repository at this point in the history

  3. Add deprecation flags

    @westonruter
    westonruter committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    e8f290b View commit details
    Browse the repository at this point in the history

  4. Move additional deprecated files to deprecated.php

    @westonruter
    westonruter committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    fcb344c View commit details
    Browse the repository at this point in the history

  5. Remove usage of deprecated function

    @westonruter
    westonruter committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    c31f190 View commit details
    Browse the repository at this point in the history

  6. Discontinue requiring unused amp-post-template-functions.php in theme… 

    … support
    @westonruter
    westonruter committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    9fb3514 View commit details
    Browse the repository at this point in the history

  7. Remove restrictions on use of important and 50KB style limit when dir… 

    …ty styles allowed
    @westonruter
    westonruter committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    56a7f1c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Use AMP__DIR__ instead of __DIR__

    @westonruter
    westonruter committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    4e64c14 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of github.com:ampproject/amp-wp into update/re… 

    …ader-mode-templates

* 'develop' of github.com:ampproject/amp-wp:
  Ensure Stories preview meets minimum viewport requirements. (#3797)
  Fix expanded menu when screen width is <1000px for Twenty Twenty theme (#3790)
  Ignore test utils from code coverage
    @westonruter
    westonruter committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    968f594 View commit details
    Browse the repository at this point in the history