Add caption support to all amp-instagram embeds #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the attribute be included in the |
…ode' method as well
chandrapatel
commented
Sep 17, 2018
| @@ -145,6 +146,7 @@ private function create_amp_instagram_and_replace_node( $dom, $node ) { | |||
|
|
|||
| $new_node = AMP_DOM_Utils::create_node( $dom, $this->amp_tag, array( | |||
| 'data-shortcode' => $instagram_id, | |||
| 'data-captioned' => '', | |||
There was a problem hiding this comment.
@westonruter I think, include this attribute if <blockquote class="instagram-media"> element has data-instgrm-captioned attribute. Please let me know your suggetion.
There was a problem hiding this comment.
@chandrapatel excellent point. Yes indeed. So only add the data-captioned attribute if $node->hasAttribute( 'data-instgrm-captioned' ).
There was a problem hiding this comment.
Thanks, I've made changes and PR updated.
westonruter
approved these changes
Sep 17, 2018
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822