Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve URL Listing view #1397

Merged
merged 63 commits into from
Sep 16, 2018
Merged

Improve URL Listing view #1397

merged 63 commits into from
Sep 16, 2018

Commits on Aug 30, 2018

  1. Start with listing view design improvements.

    @miina
    miina committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    0131c71 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Merge remote-tracking branch 'origin/develop' into 1362-improved_url_… 

    …listing_view
    @miina
    miina committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    1e2dccf View commit details
    Browse the repository at this point in the history

  2. Add icons. Add tooltip skeleton. Fix sources.

    @miina
    miina committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    fd51be5 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. Conform to validation error data model. 

    It look like there aren't double-nested 'source' arrays.
So remove the nested foreach loop.
    @kienstra
    kienstra committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    8ab7166 View commit details
    Browse the repository at this point in the history

  2. Merge in develop, resolve conflict. 

    In the develop branch,
filter_views_edit() is removed entirely,
while it was simply edited in this branch:
1362-improved_url_listing_view
So favor the develop branch,
where it's removed.
    @kienstra
    kienstra committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    b31d123 View commit details
    Browse the repository at this point in the history

  3. Update status names to latest design 

    For example, change 'To Fix Later' to 'Rejected'.
Also, update the labels.
I don't think all of them need to have 'Errors by URL',
like 'No errors by URL found'.
    @kienstra
    kienstra committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    99a35b8 View commit details
    Browse the repository at this point in the history

  4. Use dashicons for tooltip icon

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    e263b55 View commit details
    Browse the repository at this point in the history

  5. Add admin-tables.css file

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    9e99f1a View commit details
    Browse the repository at this point in the history

  6. Hide tooltip

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    273cccf View commit details
    Browse the repository at this point in the history

  7. Target class instead of id and add color to icon

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    df68ed8 View commit details
    Browse the repository at this point in the history

  8. Change Plug-In to Plugin

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    54ae458 View commit details
    Browse the repository at this point in the history

  9. Fix variable typo

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    4075cb0 View commit details
    Browse the repository at this point in the history

  10. Add plugin icon with color from design

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    9094366 View commit details
    Browse the repository at this point in the history

  11. Add theme icon with color

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    604c4b9 View commit details
    Browse the repository at this point in the history

  12. Remove extra linebreaks

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    90b4920 View commit details
    Browse the repository at this point in the history

  13. Add containers around sources for styling

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    0be3a56 View commit details
    Browse the repository at this point in the history

  14. Add margins around sources containers

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    1cb3da7 View commit details
    Browse the repository at this point in the history

  15. Add color to WP icon

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    49ca0d8 View commit details
    Browse the repository at this point in the history

  16. Change wording - found to removed

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    6d7f35b View commit details
    Browse the repository at this point in the history

  17. Add icons to status column

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f6a0878 View commit details
    Browse the repository at this point in the history

  18. Add amp logo icon class

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    c71addb View commit details
    Browse the repository at this point in the history

  19. Add error-status class

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    ca2e7d2 View commit details
    Browse the repository at this point in the history

  20. Style error statuses

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    36564fd View commit details
    Browse the repository at this point in the history

  21. Add closing span tag

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    736b2f2 View commit details
    Browse the repository at this point in the history

  22. Add color to removed elements column text

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    7af56d6 View commit details
    Browse the repository at this point in the history

  23. Add class to warning icons for styling

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    25ab2b3 View commit details
    Browse the repository at this point in the history

  24. Add color to identified and rejected icons

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    139883e View commit details
    Browse the repository at this point in the history

  25. Fix translation functions, switch to esc_html__

    @jacobschweitzer
    jacobschweitzer committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    2583e44 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. Add plugins icon when there is multiple plugins

    @jacobschweitzer
    jacobschweitzer committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    8649b91 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. Hide invalid sources if more than 1 and add icon

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    53021cc View commit details
    Browse the repository at this point in the history

  2. Only enqueue stylesheet on its post type screens

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    e87cca2 View commit details
    Browse the repository at this point in the history

  3. Add common container class for sources

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    8aebc0c View commit details
    Browse the repository at this point in the history

  4. Add JS for admin tables expand and collapse

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    9ae7e58 View commit details
    Browse the repository at this point in the history

  5. Add margin after source container

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    ffb3fdc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into 1362-improved_url_listing_view 

    # Conflicts:
#	includes/validation/class-amp-invalid-url-post-type.php
    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    ab73ddf View commit details
    Browse the repository at this point in the history

  7. Remove todo

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    4f14433 View commit details
    Browse the repository at this point in the history

  8. Change wording: Removed to Invalid

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    bda4140 View commit details
    Browse the repository at this point in the history

  9. Wrap in <code> and add brackets for attributes

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    c5ad3e6 View commit details
    Browse the repository at this point in the history

  10. Fix translation function reference

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    4ea9638 View commit details
    Browse the repository at this point in the history

  11. Add double arrow to Sources column

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    392ee24 View commit details
    Browse the repository at this point in the history

  12. Add hide all sources functionality and styles

    @jacobschweitzer
    jacobschweitzer committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    163908e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2018

  1. Change new status icons based on AMP options

    @jacobschweitzer
    jacobschweitzer committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    0ad0cf6 View commit details
    Browse the repository at this point in the history

  2. Combine duplicated post_row_actions filters; ensure only relevant lin… 

    …ks included
    @westonruter
    westonruter committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    d4b586f View commit details
    Browse the repository at this point in the history

  3. Re-use AMP_Validation_Manager::is_sanitization_forcibly_accepted()

    @westonruter
    westonruter committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    1ab6bd3 View commit details
    Browse the repository at this point in the history

  4. Add view errors by type title link button

    @jacobschweitzer
    jacobschweitzer committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    7eafdc6 View commit details
    Browse the repository at this point in the history

  5. Change title of page and highlight word URL

    @jacobschweitzer
    jacobschweitzer committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    5b9b243 View commit details
    Browse the repository at this point in the history

  6. Bolder font weight for page title action link keyword

    @jacobschweitzer
    jacobschweitzer committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    52babee View commit details
    Browse the repository at this point in the history

  7. ESLint fixes

    @jacobschweitzer
    jacobschweitzer committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    8f88d0c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Fix PHP 5.3 compatibility issues

    @jacobschweitzer
    jacobschweitzer committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1d95cae View commit details
    Browse the repository at this point in the history

  2. Update tests to reflect changes

    @jacobschweitzer
    jacobschweitzer committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    a4bdee9 View commit details
    Browse the repository at this point in the history

  3. Update to tests and add an error check

    @jacobschweitzer
    jacobschweitzer committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    fe7e4de View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Address unit test errors 

    Updates the unit tests to the latest changes
They now pass locally.
    @kienstra
    kienstra committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    6936f05 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 1362-improved_url_listing_view

    @kienstra
    kienstra committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    4cbee48 View commit details
    Browse the repository at this point in the history

  3. Addres PHPCS warning by aligning = 

    The build failed, with:
Equals sign not aligned with surrounding assignments.
So address this by aligning the =
    @kienstra
    kienstra committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    2ce2e5e View commit details
    Browse the repository at this point in the history

  4. Get full plugin names and fix theme source output

    @jacobschweitzer
    jacobschweitzer committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    74feb85 View commit details
    Browse the repository at this point in the history

  5. Code review changes and text changes

    @jacobschweitzer
    jacobschweitzer committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    5baae3f View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. Unify JS for text expansion and update styles

    @jacobschweitzer
    jacobschweitzer committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    6911305 View commit details
    Browse the repository at this point in the history

  2. Implement workaround to fix JS not loading issue

    @jacobschweitzer
    jacobschweitzer committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    56915da View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2018

  1. Update unit tests based on latest changes

    @jacobschweitzer
    jacobschweitzer committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    6488c05 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 1362-improved_url_listing_view

    @jacobschweitzer
    jacobschweitzer committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    88e7b7e View commit details
    Browse the repository at this point in the history

  3. Fix test listing amp plugin

    @jacobschweitzer
    jacobschweitzer committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    145a9ef View commit details
    Browse the repository at this point in the history

  4. Fix unit tests

    @jacobschweitzer
    jacobschweitzer committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    6624e68 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. Apply remaining changes from code review 

    * Output theme name if available instead of theme slug.
* Fix logic for obtaining plugin name when plugin is not in directory or plugin file doesn't use slug.
* Use innerText instead of innerHTML for security hardening.
* Better encapsulate logic in \AMP_Validation_Error_Taxonomy::render_link_to_errors_by_url().
* Add missing @wordpress/dom-ready dependency to fix workaround 56915da described in #1397 (comment)
* Update button from "View errors by URL" to "View Invalid URLs".
    @westonruter
    westonruter committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    716a869 View commit details
    Browse the repository at this point in the history