Respect default AMP enabled status when creating a new post in Gutenberg #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When first loading a new post, AMP status has not been set yet by the Enable AMP toggle. Instead, we'll use default status.
westonruter
approved these changes
Aug 14, 2018
westonruter
changed the title
|
Moving To 'Ready for Merging' If it's alright, I'm moving this to 'Ready for Merging,' as I'm not sure it needs functional testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When first loading a new post, AMP status has not been set yet been saved as meta. Though the Enable AMP toggle shows it as enabled, it's using
window.wpAmpEditor.defaultStatusto set the default status.This PR uses that same strategy for block validation.