Define get_post_permalinks().
This gets permalinks for public posts,
other than attachments.
Another helper function can call
AMP_Validation_Manager::validate_url()
for each of these permalinks.

validate_queued_posts_on_frontend() uses IDs,
which are stored in
$posts_pending_frontend_validation.
So simply return IDs from the helper function.

Before, $post_ids wasn't assigned as an array().
This addresses a failed Travis build.

Querying for ID was simply to make testing easier.
So remove that, and fall back to the default
'orderby' => 'date'.

This class is not going to use this method anymore:
validate_queued_posts_on_frontend().
So this will need the permalinks, not IDs.

For example, http://example.org/?cat=2
This includes categories and tags,
and any more that are registered.
But it excludes post_format links.

Before, I had unset() these from the array.
But as Weston pointed out,
post_format terms can have archive links.

Add a $taxonomy parameter,
to only get the terms for a given taxonomy.

As Weston mentioned,
this helps to get the links in batches.
Also, simplify the test.

Props 10up Engineering Best Practices.
The prevents the need to use
wp_list_pluck() to get the ids.

A similar change to the one Weston proposed
for get_taxonomy_links().
Get permalinks by post types,
and allow paging through them.
This will allow iteration, in a way similar to
that in get_taxonomy_links().

Iterate over all of the terms and posts
from the existing helper methods.
@todo: consider self::BATCH_SIZE,
and whether the validation requests
should be throttled,
or somehow prevented from timing out WP.

In PHP 5.3, there was:
Fatal error: Cannot access self:: when no class scope is active.
https://travis-ci.org/Automattic/amp-wp/jobs/386045157.

This looks to be because self isn't
available inside the function in 5.3.
Another option might be to add $self to use().
But this seems simpler, if it works.

This will enable crawling the site in Native AMP.
This seems simpler than registering Paired Mode
support, and adding template_dir.
But it's still an open discussion as to
whether it should only be Native AMP.
If this already finds theme support,
it doesn't change it.

In the validate_url() helper function,
find if it's in Paired Mode.
If so, set the $url to the amp endpoint.

This mainly calls the existing helper function.
But it also passes it $wp_cli_progress.
This advances the progress bar,
after each post type or taxonomy validation completes.

Success: 196 URLs were crawled, and 196 have AMP validation issue(s).
Query for the validation error posts.
And output the number found.

This drives to the page:
Invalid AMP Pages (URLs)

Also, output a message at the beginning:
Crawling the entire site to test for AMP validity.
This might take a while...

3 assertions failed,
so fix these both in the tested class
and the PHPUnit class.

On Weston's suggestion.
Before, running the validation required:
wp eval-file bin/validate-site.php.

This has a much better display of the activity.
On Weston's suggestion.
Create a new method to count all of the URLs
to be validated.
This should only be used for WP-CLI,
as it uses 'posts_per_page' => -1

There's now more accurate feedback
in the progress bar,
and it'll be clear that this will
probably take more than a minute.

If a script is enqueued on all pages,
and the user has accepted that error,
there's probably no need to report all of the
URLs that have that issue.

This stores the URLs in a property,
so there's no need to also return that property.

This isn't needed, as validate_url()
can add the AMP query arg if needed.

regardless of whether they were accepted.
This is just to be able to demo this work.
It probably still makes more sense to only
show errors that weren't accepted.

validate_url() can already simulate theme support.
So there's no need to do this before.

Before, this didn't account for 'attachment' posts.
It needs a special WP_Query, as
their post_status is usually inherit.

Before, this simply counted all of the errors.
But there could be an accepted script removal,
and this could result in errors being
reported for the entire site.
So also output the number of unaccepted errors.

AMP_Site_Validation::$site_invalid_urls stored these.
But this doesn't seem to be needed.
A WP_Query() could later find any invalid URLs.

This passes 'posts_per_page' => -1 to WP_Query.
It's a performance risk,
and is only intended for use in the WP-CLI command.

Add more DocBlock descriptions,
and update descriptions.

This should have an argument of an array,
not a string.

crawl_site() needs to be static,
as it's called statically,
and there isn't yet a meants of bootstrapping.

Add a description about how to run the command.
And remove an extra empty line.

    As Weston suggested,
    this passes 'orderby' => 'ID' to WP_Query(),
    so it's alright if another post is added during the query.
    Also, this increments the offset each query.

All of the created posts had a term of 'Uncategorizes' added.
Before, 'Uncategorized' wasn't countent in the term query,
because there were no posts.
So create a new term to add to all of the posts,
and count it.
So 'Uncategorized' won't be part of the term query,
as it has no posts associated with it.

Instead of having this conditional block in 2 places,
simply place it at the top.
It was going to run either way, and this is simpler.

Improve the DocBlocks and inline documentation.
Also, remove a duplicated line.

If the property is true,
force counting and crawling non-AMP-enabled URLs.
The default behavior is to skip any URLs
that are explicitly opted-out of AMP.
Like if you uncheck 'Enable AMP' in the post editor.

Like the previous commit a53bb45,
but for taxonomies.
This applies to default taxonomies
and custom taxonomies.

…ented)

Add a flag --force-validate-all
If it's added to the command wp amp validate-site,
This will validate all URLs,
regardless of whether a user has opted-out of the template,
like by unchecking 'Categories' in
'AMP Settings' > 'Supported Templates'.

In 'AMP Settings,' users can uncheck certain templates.
And this had blocked validation of them,
as is_amp_endpoint() returned false and they were redirected.
So if the user passes the flag to the WP-CLI command,
add a query var.
This forces all endpoints to be AMP endpoints, to allow validation.
Still, is_amp_endpoint might not be the right
place to make this change.

Before, there was an issue when
$amp_enabled_taxonomies was an empty array().
Then, the WP_Term_Query() returned terms
from all taxonomies.
So simply don't run the query if there
are no AMP-enabled taxonomies.

On Weston's suggestion,
this can have whitelisted conditionals.
For example, --include=is_tag,is_author.

If the --include argument doesn't include the
taxonomy conditional, like is_category,
don't validate it.
For posts, if there's an include argument that
does no include is_singular,
don't allow any posts.

Also, set $force_crawl_urls if there's an include argument.
You could pass a conditional to include that
has AMP disabled now.
Like if you use the command:
wp amp validate-site include=is_author
But 'Author' could be unchecked in
'AMP Settings' > 'Supported Templates'
In that case, this would need to force
validation of that URL,
as the URL would otherwise redirect to the non-AMP URL.

Also, decompose duplicated logic into
is_template_supported().

This is most likely if all of the templates in
Supported Templates are unchecked.
Add a message that passing --force-validation
to the command could help.

As Alberto and Weston suggested,
the site crawling could validate one URL
of each template at a time.
This prevents validating possibly thousands of
posts or pages before getting to other URLs.
So this accepts an $offset argument.
0 gets the first user, and 1 the second...
The optional second parameter sets a number to return.
So in the round-robin validation,
this could be 1.

As Alberto and Weston suggested,
this validates one URL of each type at a time,
up to a limit of maximum URLs to validate.

This shouldn't count over the maximum URL number,
as they won't be validated.

Thanks to Alberto's suggestion
This sets the maximum number of URLs
that are validated for each type.
For example, if it's 10,
this validates 10 categories, 10 tags, etc...

If there's an argument and is_home is not in it,
don't validate the homepage.
Also, only validate it specifically
if the user has selected
Your homepage displays > Your latest posts.

Because validation is round-robin,
only validating a single URL at a time,

This is probably more useful to know
than simply how many total URLs are valid.

Use a simply mock query string, like:
https://example.com/?year=2018

There was always an argument for $number,
so there's no need for a default value in the definition.
Also, improve inline documentation.

The test still passes when testing attachments.
Also, other minor changes,
and documentation improvements.

A unit test is failing,
so test removing the array_merge() call.

This reverts commit 3dac2fd.

In count_urls_to_validate(),
this should count the example date page,
as it's being validated.

Before, the error message suggested that this
was an issue in the /wp-admin UI.
But this outputs a message that's more accurate for this case.

…alid-site

Show URL count and validity rate as two columns, as opposed to single ratio column.

On Weston's suggestion, as this would not be
able to validate any URL without the --force flag.

As Weston suggested,
if in Classic mode and --force is passed,
force theme support in the crawled URLs.
This is now done in read_theme_support(),
thought there might be a better way.

* Only show admin URL to review results if theme support initially present.
* Skip showing table if no results obtained.

…sic mode

… and taxonomy

* Hide the admin menu links for invalid URLs and validation errors by default in classic mode.
* Invoking `wp amp validate-site` will cause the post type and taxonomy to be populated.
* When in classic mode, show links to invalid pages and validation errors with template mode as opposed to in admin menu.
* When viewing the admin screens for the post type and taxonomy, show the admin menu links for both.

…nce with limit