Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for (canonical) theme support #868

Closed
westonruter opened this issue Jan 16, 2018 · 2 comments
Closed

Add test coverage for (canonical) theme support #868

westonruter opened this issue Jan 16, 2018 · 2 comments
Milestone
v0.7

Comments

@westonruter
Copy link
Member

westonruter commented Jan 16, 2018 •
edited
Loading

In prototyping the approach for adding theme support, unit testing has not been rigorously followed. Once the approach and architecture for theme support settles, test coverage needs to be ensured for the new functionality.

Include:
@westonruter westonruter added this to the v0.7 milestone Jan 16, 2018
@westonruter westonruter mentioned this issue Jan 16, 2018
Merged
1 task
@westonruter
Copy link
Member Author

Current state of coverage as of f957712:

image

@westonruter westonruter mentioned this issue Mar 22, 2018
Merged
@DavidCramer
Copy link
Contributor

DavidCramer commented Mar 28, 2018 •
edited
Loading

Current state of coverage as of 1b75fae
screen shot 2018-03-28 at 12 15 14

This was referenced Mar 30, 2018
Closed
Merged
westonruter added a commit that referenced this issue Apr 3, 2018
@westonruter
Merge pull request #1049 from Automattic/add/868-comments-unit-tests
4848408 
Issue #868: Add Comment Unit Tests for PR #909
@kienstra kienstra closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
5 participants
@westonruter @DavidCramer @ThierryA @kienstra @MackenzieHartung