Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-fetch from 2.6.0 to 2.6.1 #919

Merged
merged 4 commits into from
Oct 11, 2020
Merged

Conversation

daggy1234
Copy link
Contributor

While a low severity issue, node-fetch 2.6.0 has vulnerabilities. It is a good idea to bump node-fetch used from 2.6.0 to 2.6.1.

https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v261

Thats about it!

@google-cla
Copy link

google-cla bot commented Sep 11, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 11, 2020
@daggy1234
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 11, 2020
@esimons
Copy link

esimons commented Sep 11, 2020

Possible to piggyback a patch update of the cross-fetch dependency? Related request in that the current version specified (cross-fetch@3.0.5) itself has an inflexible dependency on node-fetch@2.6.0 --- updating to cross-fetch@3.0.6 should update the transitive node-fetch dep per lquixada/cross-fetch@1d277e5

Edit: Can we also expand scope of PR to include additional packages? e.g. lighthouse-plugin-amp; toolbox-linter; toolbox-cli

@DullReferenceException
Copy link

Related: #916

@daggy1234
Copy link
Contributor Author

So based on the discussion, I bumped both cross-fetch and node-fetch to semver. All instances of both were bumped!

@kmdev1
Copy link

kmdev1 commented Sep 30, 2020

Thanks @daggy1234 for creating a PR!

What's the best away getting around to getting this merged? 🎉 It'd be great to see the vulnerability patched 😄

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020

CLA assistant check
All committers have signed the CLA.

@daggy1234
Copy link
Contributor Author

I think its ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants