Merge pull request #918 from schlessera/fix/917-missing-closing-amp-i…

…mg-tags Add missing closing tags to <amp-img> elements
ampproject · Oct 11, 2020 · 77c3515 · 77c3515
2 parents 332a1a9 + f984f76
commit 77c3515
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/.../spec/transformers/valid/PreloadHeroImage/srcset_cannot_be_preloaded/expected_output.html b/.../spec/transformers/valid/PreloadHeroImage/srcset_cannot_be_preloaded/expected_output.html
@@ -2,10 +2,8 @@
 <head></head>
 <body>
   <!-- srcset is not supported by all browsers -->
-  <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png" srcset="test 100w test2 3dpr" i-amphtml-ssr data-hero>
-    <!-- not preloaded as it's not a hero image -->
-    <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png">
-    </amp-img><img class="i-amphtml-fill-content i-amphtml-replaced-content" decoding="async" src="https://example-com.cdn.ampproject.org/foo.png" srcset="test 100w test2 3dpr">
-  </amp-img>
+  <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png" srcset="test 100w test2 3dpr" i-amphtml-ssr data-hero><img class="i-amphtml-fill-content i-amphtml-replaced-content" decoding="async" src="https://example-com.cdn.ampproject.org/foo.png" srcset="test 100w test2 3dpr"></amp-img>
+  <!-- not preloaded as it's not a hero image -->
+  <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png"></amp-img>
 </body>
 </html>
diff --git a/.../optimizer/spec/transformers/valid/PreloadHeroImage/srcset_cannot_be_preloaded/input.html b/.../optimizer/spec/transformers/valid/PreloadHeroImage/srcset_cannot_be_preloaded/input.html
@@ -2,8 +2,8 @@
 <head></head>
 <body>
   <!-- srcset is not supported by all browsers -->
-  <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png" srcset="test 100w test2 3dpr">
+  <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png" srcset="test 100w test2 3dpr"></amp-img>
   <!-- not preloaded as it's not a hero image -->
-  <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png">
+  <amp-img width="500" height="400" src="https://example-com.cdn.ampproject.org/foo.png"></amp-img>
 </body>
 </html>