AMP-101866 textarea serialization fix #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix serialization and mutation of <textarea> elements taking account the duality that the value can be set in either the child node, or in the value _parameter_ (not attribute) * Backwards compatibility: Bug fix and regression test for rrweb-io#112 - this is to fix up 'historical' recordings, as duplicate textarea content should no longer be being created at record time - new test shows what the snapshot generated by previous versions of rrweb used to look like, hence 'bad' - original 0efe23f fix either didn't work or no longer works due to childNodes being appended subsequent to this part of the code - during review, we also verified that the `_cssText` case should still be handled okay, as there's currently no scenario where csstext is present with css child nodes of a <style> * Masking: Fix that textarea values were being missed by the masking system if the value was recorded as a child node - I didn't notice that form.html was used in other tests, so lucky that I noticed that those tests also should have the 'pre value' masked out * Simplify by always storing the textarea value in the `.value` attribute (from it's DOM property) and not as a childNode. It should still be rebuilt as a childNode rather than a property --------- Authored-by: eoghanmurray <eoghan@getthere.ie>
🦋 Changeset detectedLatest commit: fb39603 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kwalker3690
approved these changes
Aug 1, 2024
jxiwang
reviewed
Aug 1, 2024
.changeset/moody-dots-refuse.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'rrweb': patch | |||
There was a problem hiding this comment.
Need to change to @amplitude/rrweb
|
Should try and test before releasing at least on SR SDK side. |
|
@jxiwang so the replay I linked was using this new patch. Though I hadn't tested for regressions. I can run the playwright scripts I have against the tasks app though before merging. Also I wasn't sure if you had anything specific to look out for. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in a nice fix around textarea serialization from upstream. This should prevent duplicate values in textareas.
Example replay:
https://app.amplitude.com/analytics/amplitude/session-replay/project/626195/search/amplitude_id%3D956525072689?sessionHandle=ZEOcNRF_ZEOcNRF_N61VlEx_CY4T_99f59631-290b-4960-a509-3a4d757f69b2&sessionReplayId=99f59631-290b-4960-a509-3a4d757f69b2/1722524161093&sessionLength=9414&sessionStartTime=1722524161093&deviceType=&user_id=&country=United%20States