Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added provider.profile support #575

Merged
merged 4 commits into from
May 5, 2023
Merged

Added provider.profile support #575

merged 4 commits into from
May 5, 2023

Conversation

rddimon
Copy link
Collaborator

@rddimon rddimon commented May 4, 2023

Fixes #572

Description of Issue Fixed
Added support for the SLS provider.profile option

Changes proposed in this pull request:

  • Updated logic for supporting provider.profile
  • Updated test
  • Updated packages

@rddimon rddimon added the bug label May 4, 2023
@rddimon rddimon self-assigned this May 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rddimon rddimon merged commit 1af9b67 into main May 5, 2023
5 checks passed
@rddimon rddimon deleted the provider-profile-support branch May 5, 2023 07:16
@rddimon rddimon mentioned this pull request May 5, 2023
Closed
@rddimon rddimon linked an issue May 9, 2023 that may be closed by this pull request
v7.0.2 sls create_domain fails #573
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoskotsky-amplify aoskotsky-amplify aoskotsky-amplify approved these changes

@IButskhrikidze IButskhrikidze IButskhrikidze approved these changes

@mluhovyi mluhovyi mluhovyi approved these changes

Assignees

@rddimon rddimon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7.0.2 sls create_domain fails Update to v7.x.x gives warning that domain does not exist
4 participants
@rddimon @aoskotsky-amplify @IButskhrikidze @mluhovyi