-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Store the dimensions into dimens resource file #69
Conversation
@hridyakrishna please follow semantic pr guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where ever there's a padding of 0dp, instead of giving different names everytime, use a common name like padding_zero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that dimens are 20, 120, 5, 45, 50 mostly. Instead of creating different names for each dimension in the different files, create a common name. For example, if padding 20 is in many places, make it padding_twenty
everywhere.
If it is height 20, then change it to height_20
.Do the same for all other dimensions.
Try to use minimum dimensions in order to minimize the size of the app.
@hridyakrishna thanks, good job 👍. Just some minor changes are needed. Please do those 😄 |
@yashk2000 Yes, I will make the suggested changes. |
@hridyakrishna Great 😄 |
@hridyakrishna can you please follow semantic pr guidelines. and the title, commit message can be |
@hridyakrishna great job. Almost perfect. Just follow the semantic pr guidelines please in the future. |
Fixed #50
Changes: The dimensions in the XML files were hardcoded. Stored them into dimens resource folder.
Changed files: activity_main.xml, delete_data.xml, insert_data.xml, layout_row_view.xml,
read_all.xml, read.data.xml, update_data.xml, dimens.xml