fixes #12: It will be better to restrict user to add either "user ID" or "name", without leaving both details empty #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2000
reviewed
Jun 10, 2019
| } else { | ||
| money = moneyDonated.getText().toString(); | ||
| overall = money + getResources().getString(R.string.empty) + name + getResources().getString(R.string.empty) + paidCheck; | ||
| if (id.length() == 0) { |
ajay-prabhakar
approved these changes
Jun 10, 2019
yashk2000
reviewed
Jun 10, 2019
| } else { | ||
| money = moneyDonated.getText().toString(); | ||
| overall = money + getResources().getString(R.string.empty) + name + getResources().getString(R.string.empty) + paidCheck; | ||
| if (id.length() == 3) { |
There was a problem hiding this comment.
It won't accept length > 3, please change that.
There was a problem hiding this comment.
no @yashk2000 ...actual length of id is 3..i.e if nothing is entered..id length will be 3,then it wont allows the user...so if anything is entered,it will be greater than 3 and it allows the user.
yashk2000
approved these changes
Jun 10, 2019
|
Looks everyone is satisfied with the work. Thanks, @mustaqmustu 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12
Screenshots of the change:
