Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Support a user defined name for the schema_migrations table #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andrevdm
Copy link

Added runMigration' and runMigrations'. These two function support an extra parameter over the non-prime ones. This param is the name of the scschema_migrations table that the user has selected.

Adding two new functions like this means there are no breaking changes for existing users.

@andrevdm
Copy link
Author

Useful e.g. where you have a DB build with multiple migration tools that both want to write to schema_migrations

@ford-prefect
Copy link

@ameingast is this something you would accept? I'd also like to have similar functionality (in my case, to force the schema_migrations to be part of the same schema as the rest of my tables.

@ameingast
Copy link
Owner

Yup, as long as full backwards compatibility is guaranteed, this will be merged in, once I have some time on my hands.

@ford-prefect
Copy link

@andrevdm will you be rebasing this change on current master? If not, I can take a stab at doing this.

@andrevdm
Copy link
Author

andrevdm commented Jul 2, 2020 via email

Added runMigration' and runMigrations'. These two function support an
extra parameter over the non-prime ones. This param is the name of the
scschema_migrations table that the user has selected.

Adding two new functions like this means there are no breaking changes
for existing users.
@andrevdm
Copy link
Author

andrevdm commented Jul 2, 2020

rebased on master and pushed. I'll do a few more tests now

@andrevdm
Copy link
Author

andrevdm commented Jul 2, 2020

There is a bit of duplication in the code, e.g. MigrationContext' vs MigrationContext but think its justified for backwards comparability.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants