This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Scan line padding (take 2) #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19f22bf fixed this for macOS but not for iOS.
19f22bf currently breaks calculations of aHash and pHash: For an image width of 8 pixels OS_ALIGN advices a 64-byte scanline, adding 32 bytes of zero-padding, but the aHash and pHash implementations in OSFastGraphics expect 32-byte scanlines without any padding. This commit introduces an inline mediator function to force a 32-byte scanline for images with an width of 8 pixels.
|
Great stuff, thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two problems introduced by 19f22bf:
As a fix, an inline function, used by both macOS and iOS, is introduced that forces 32 bytes per row for aHash and pHash. Also, a basic test is added to detect obvious padding misconfigurations.