Publishing 0 for cpu/memory over metrics when limit/resource not set #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
approved these changes
Sep 19, 2023
chadpatel
approved these changes
Sep 20, 2023
mitali-salvi
merged commit 4452da3
into
amazon-contributing:aws-cwa-dev
3 checks passed
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
mitali-salvi
added a commit
to mitali-salvi/opentelemetry-collector-contrib
that referenced
this pull request
Nov 2, 2023
…not set (amazon-contributing#95)" This reverts commit 4452da3.
mitali-salvi
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Bug fix - emit a value of 0 for the following metrics when the pod cpu/memory limits are not set
cpu_utilization_over_pod_limit
cpu_utilization_over_container_limit
memory_utilization_over_pod_limit
memory_utilization_over_container_limit
Testing:
Tested on my testing cluster