Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nil referencing issue in cadvisor during metric decoration #206

Merged
merged 1 commit into from
May 3, 2024
Merged

fix nil referencing issue in cadvisor during metric decoration #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions receiver/awscontainerinsightreceiver/internal/cadvisor/cadvisor_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ func (c *Cadvisor) GetMetrics() []pmetric.Metrics {
}

for _, cadvisorMetric := range results {
if cadvisorMetric == nil {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we including nils in the result slice in the first place?

Copy link
Author

@movence movence May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens when pod information is not found in store (PodStore or ServiceStore) cache while decorating metrics with k8s metadata or service. It is unknown why corresponding pod information is missing for a metric, but this adds a safe guard around this edge case.

continue
}
md := ci.ConvertToOTLPMetrics(cadvisorMetric.GetFields(), cadvisorMetric.GetTags(), c.logger)
result = append(result, md)
}
Expand Down
Loading