change: Ignore qubit_count parameter for JAQCD
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 3790 3791 +1
Branches 927 927
=========================================
+ Hits 3790 3791 +1 ☔ View full report in Codecov by Sentry. |
rmshaffer
approved these changes
Jun 27, 2024
|
@speller26 I think you should go ahead and merge this, especially if it unblocks your work on #264 |
krneta
approved these changes
Jun 27, 2024
krneta
reviewed
Jun 27, 2024
| @@ -642,7 +642,7 @@ def run_jaqcd( | |||
| Args: | |||
| circuit_ir (Program): ir representation of a braket circuit specifying the | |||
| instructions to execute. | |||
| qubit_count (int): The number of qubits to simulate. | |||
| qubit_count (int): Unused parameter; in signature for backwards-compatibility | |||
There was a problem hiding this comment.
Should we default to None and log a warning if this value is specified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.