Skip to content
This repository has been archived by the owner on Feb 24, 2018. It is now read-only.

Adds a podspec for CocoaPods support #644

Merged
merged 1 commit into from
Jan 27, 2018
Merged

Adds a podspec for CocoaPods support #644

merged 1 commit into from
Jan 27, 2018

Conversation

terribleben
Copy link
Contributor

Motivation

react-native link now supports CocoaPods projects. If somebody wants to use the existing react-native link instructions to add Cognito to their CocoaPods-enabled project, it needs a podspec to link properly. This PR adds that podspec.

As a nice side effect, it also removes the need for those projects to depend on vendored JKBigInteger code, since it just expresses that library as a CocoaPods dependency.

How to test

Follow the Install for React Native instructions from this repo's README on an iOS project that uses CocoaPods. You'll need to use a copy of the JS that includes this change. You can also install manually by adding RNAWSCognito to the project's Podfile.

@minbi
Copy link
Contributor

minbi commented Jan 9, 2018

What does this imply for projects that are not using Cocoapods? Does this force the usage of pods?

@terribleben
Copy link
Contributor Author

terribleben commented Jan 9, 2018

No, those projects will not be affected. react-native link will only use the newer CocoaPods behavior if the user's project contains a Podfile. So other projects which don't use CocoaPods can continue unchanged from their existing setup.

@itrestian itrestian merged commit 7416921 into amazon-archives:master Jan 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants