Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for permanentRedirect #715

Closed
amannn opened this issue Dec 11, 2023 · 0 comments · Fixed by #850
Closed

Add support for permanentRedirect #715

amannn opened this issue Dec 11, 2023 · 0 comments · Fixed by #850
Labels
contributions welcome Good for people looking to contribute enhancement New feature or request

Comments

@amannn
Copy link
Owner

amannn commented Dec 11, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

We already support redirect for 307 status codes, but Next.js has added permanentRedirect for 303/308 status codes in the meantime.

Describe the solution you'd like

Akin to redirect, the factory functions for creating navigation APIs should return a permanentRedirect function (based on the one from Next.js).

Describe alternatives you've considered

Wrap the function from Next.js in userland.

Context

Relevant tests:

Relevant source files to adapt:
@amannn amannn added enhancement New feature or request unconfirmed Needs triage. contributions welcome Good for people looking to contribute and removed unconfirmed Needs triage. labels Dec 11, 2023
@polvallverdu polvallverdu mentioned this issue Feb 9, 2024
Merged
amannn added a commit that referenced this issue Feb 9, 2024
@polvallverdu @amannn
feat: Add support for permanentRedirectin navigation APIs (#850 by @…
6508ddc 
…polvallverdu)

Fixes #715

---------

Co-authored-by: Jan Amann <jan@amann.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome Good for people looking to contribute enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for permanentRedirect
1 participant
@amannn