feat: link contact_person(LAN-699) (Sourcery refactored) #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://github.com/avatars/in/48477?s=60&v=4){kind=small}
| frappe.delete_doc( | ||
| "User", | ||
| user, | ||
| ignore_permissions=True, | ||
| ignore_missing=True, | ||
| delete_permanently=True, | ||
| ) | ||
|
|
||
| delete_dynamically_linked("Address", self.doctype, self.name) | ||
| delete_dynamically_linked("Contact", self.doctype, self.name) | ||
| delete_records_linked_to("LANDA Member", self.name) | ||
|
|
||
| self.revert_series() | ||
|
|
||
| def revert_series(self): | ||
| """Decrease the naming counter when the newest member gets deleted.""" | ||
| # reconstruct the key used to generate the name | ||
| number_part_len = len(self.name.split("-")[-1]) | ||
| key = f"{self.name[:-number_part_len]}.{'#' * number_part_len}" | ||
| revert_series_if_last(key, self.name) | ||
| def autoname(self): | ||
| """Generate the unique member number (name field) | ||
|
|
||
| Organization: AVL-001-0001, AVE-001-0001, ... | ||
| Local group: AVL-001-01-0001, AVL-001-02-0001, ... | ||
| """ | ||
| if self.name: | ||
| return | ||
| self.name = make_autoname(f"{self.organization}-.####", "LANDA Member") | ||
|
|
||
| def onload(self): | ||
| load_address_and_contact(self) | ||
|
|
||
| def validate(self): | ||
| if frappe.db.get_value("Organization", self.organization, "is_group"): | ||
| frappe.throw( | ||
| _("Cannot be a member of organization {} because it is a group.").format( | ||
| self.organization | ||
| ) | ||
| ) | ||
|
|
||
| self.full_name = get_full_name(self.first_name, self.last_name) | ||
|
|
||
| def on_trash(self): | ||
| current_member = get_member_and_organization(frappe.session.user)[0] | ||
| if current_member == self.name: | ||
| frappe.throw(_("You cannot delete your own member record.")) | ||
|
|
||
| if user := frappe.db.exists("User", {"landa_member": self.name}): |
There was a problem hiding this comment.
Function LANDAMember.on_trash refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #226 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!