Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MVP #1

Closed
aazuspan opened this issue Apr 6, 2024 · 3 comments · Fixed by #6
Closed

Implement MVP #1

aazuspan opened this issue Apr 6, 2024 · 3 comments · Fixed by #6
Assignees
Labels
enhancement New feature or request

Comments

@aazuspan
Copy link
Collaborator

aazuspan commented Apr 6, 2024

As discussed in google/Xee#153, I'll put together a PR with the core functionality of loading Earth Engine data into a Dask dataframe via a top-level read_ee function.

We settled on dask-geopandas as an optional dependency to enable geospatial processing on deferred dataframes, but I'm leaning towards omitting that from the MVP until geopandas/dask-geopandas#285 is merged. The alternative would be to pin to an older Dask before the incompatible query planning system was added or disable query planning in the Dask configuration. Given that there's a fix in progress, I'm in favor of just postponing that feature until it's released and then pinning to that.

That doesn't stop us from optionally using GeoDataFrames for the underlying chunks in the Dask dataframe, and if a user needs to run geospatial operations without computing they can always set their own Dask config and wrap the read_ee output in from_dask_dataframe.

Let me know if you have strong feelings on that @alxmrs - otherwise I'll move ahead with that plan.

@aazuspan aazuspan added the enhancement New feature or request label Apr 6, 2024
@aazuspan aazuspan self-assigned this Apr 6, 2024
@alxmrs
Copy link
Owner

alxmrs commented Apr 7, 2024

That plan sounds correct. Thanks for looking into the limitation, I wasn’t aware.

@aazuspan
Copy link
Collaborator Author

Sorry for dropping the ball on this - got tied up with other projects. Glad to see it come together!

@alxmrs
Copy link
Owner

alxmrs commented Jun 23, 2024

No problem at all! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants