Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: Specify rate control params for software encoding #1393

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Linux: Specify rate control params for software encoding #1393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5351032
Specify rate control params for software encoding
deiteris Jan 20, 2023
f0d7654
x264 needs bigger buffer size
nowrep Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions alvr/server/cpp/platform/linux/EncodePipelineSW.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ alvr::EncodePipelineSW::EncodePipelineSW(Renderer *render, uint32_t width, uint3
encoder_ctx->max_b_frames = 0;
encoder_ctx->gop_size = 0;
encoder_ctx->bit_rate = settings.mEncodeBitrateMBs * 1000 * 1000;
encoder_ctx->rc_min_rate = encoder_ctx->bit_rate;
encoder_ctx->rc_max_rate = encoder_ctx->bit_rate;
encoder_ctx->rc_buffer_size = encoder_ctx->bit_rate / 10;
encoder_ctx->thread_type = FF_THREAD_SLICE;
encoder_ctx->thread_count = settings.m_swThreadCount;

Expand Down Expand Up @@ -127,3 +129,9 @@ void alvr::EncodePipelineSW::PushFrame(uint64_t targetTimestampNs, bool idr)
throw alvr::AvException("avcodec_send_frame failed:", err);
}
}

void alvr::EncodePipelineSW::SetBitrate(int64_t bitrate)
{
EncodePipeline::SetBitrate(bitrate);
encoder_ctx->rc_buffer_size = bitrate / 10;
}
1 change: 1 addition & 0 deletions alvr/server/cpp/platform/linux/EncodePipelineSW.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class EncodePipelineSW: public EncodePipeline
EncodePipelineSW(Renderer *render, uint32_t width, uint32_t height);

void PushFrame(uint64_t targetTimestampNs, bool idr) override;
void SetBitrate(int64_t bitrate) override;

private:
AVFrame *encoder_frame = nullptr;
Expand Down