Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always create FFmpeg Vulkan hw context #1349

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

nowrep
Copy link
Collaborator

@nowrep nowrep commented Jan 4, 2023

Vulkan ffmpeg context is not currently needed for AMD GPUs, but it will eventually be required for Vulkan encoder.
This simplifies shared ffmpeg code and moves DRM hw context creation to VAAPI encoder.

@m00nwtchr m00nwtchr force-pushed the master branch 2 times, most recently from c4b17c0 to e79f017 Compare January 7, 2023 13:36
@nowrep nowrep force-pushed the ffmpeg-vulkanctx branch 2 times, most recently from fc65c88 to 7427e0b Compare January 7, 2023 15:56
Copy link
Collaborator

@Vixea Vixea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiled and ran on an AMD gpu just fine.

@Vixea Vixea merged commit edca3d5 into alvr-org:master Jan 11, 2023
zarik5 pushed a commit that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants