-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entropy coding option #1318
Entropy coding option #1318
Conversation
I think the default value should be CAVLC, since it's the option that behaves more consistently and gives overall lower latency. |
ada3e21
to
ea90362
Compare
6dc39f5
to
2878200
Compare
Ready to merge if it's all good. Though would be great to see some testing on nvidia cards and Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VAAPI part tested and it does actually reduce decoder latency.
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
* Add entropy coding option * Use CAVLC as default option * Update description for entropy options * Add entropy coding option to Linux * Fix indentation * Add missing break statements
In h264 codec, CABAC entropy coding may save up to 20% of the bitrate budget, but increases the decoder latency by 2+ times depending on the target bitrate and may also increase encoder load. This significantly reduces the decoder throughput which may be incomparable to gained quality, so CAVLC can be used for very high bitrate or high encoder/decoder load scenarios without significant perceived quality loss.
Graph with CAVLC
Graph with CABAC