AMF refactor #1227
Merged
AMF refactor #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
deiteris
commented
Nov 2, 2022
•
deiteris
commented
- Fixes high CPU usage (regression introduced by Introduce AMF Pre-Processor, 10-bit support and configurable encoder quality options #1220) and slightly reduces CPU usage comparing to older code.
- Moves out video transmission and encoding pipeline to separate threads.
- Remove AUD reliably for all codecs (fixes H.264 stream with 22.3.1 and 22.5.1).
- Use Infinite GOP for H.264 and HEVC encoding.
- Throw error when 10-bit mode selected with H.264.
Keeping MAX_QP as it seems to still help but in only extremely rare cases
really should've checked the headers 🤦
deiteris
commented
Nov 3, 2022
deiteris
force-pushed
the
amf-refactor
branch
2 times, most recently
from
c0342af
to
f3910ef
Compare
deiteris
force-pushed
the
amf-refactor
branch
from
f3910ef
to
4816641
Compare
Vixea
requested changes
Nov 8, 2022
Vixea
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.