Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dask and Spark DataFrame Support #2705

Merged
merged 27 commits into from
May 1, 2024

Conversation

thehomebrewnerd
Copy link
Contributor

Closes #2704

Removes support for creating EntitySets from Dask and Spark dataframes.

@thehomebrewnerd thehomebrewnerd self-assigned this Apr 15, 2024
@thehomebrewnerd thehomebrewnerd marked this pull request as draft April 15, 2024 15:59
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 99.85141% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.38%. Comparing base (21d0bf0) to head (dcee907).

Files Patch % Lines
...s/computational_backends/feature_set_calculator.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2705       +/-   ##
===========================================
+ Coverage   86.97%   99.38%   +12.41%     
===========================================
  Files         404      397        -7     
  Lines       24230    22292     -1938     
===========================================
+ Hits        21073    22156     +1083     
+ Misses       3157      136     -3021     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tamargrey
Copy link
Contributor

A couple places that probably still need to be updated:

  • __dask_tokenize__ still exists in entityset.py - probably can be removed
  • The Parallel Computation by Partitioning Data section in the performance.ipynb file has some references to spark - Not sure if we want to just remove all references entirely or leave some subset of it (maybe just reference that an old version of featuretools can be used if you want to use it with Spark), but we should definitely remove the link to the Feature Engineering on Spark Notebook, which will no longer exist.

@thehomebrewnerd
Copy link
Contributor Author

  • The Parallel Computation by Partitioning Data section in the performance.ipynb file has some references to spark - Not sure if we want to just remove all references entirely or leave some subset of it (maybe just reference that an old version of featuretools can be used if you want to use it with Spark), but we should definitely remove the link to the Feature Engineering on Spark Notebook, which will no longer exist.

@tamargrey I think those references are still valid since they relate to manually partitioning data and not doing it via pyspark dataframes in an EntitySet. The Feature Engineering on Spark Notebook will still exist here: https://github.com/alteryx/predict-customer-churn/blob/main/churn/4.%20Feature%20Engineering%20on%20Spark.ipynb. The linked article in that section is gone though, so I'll remove that reference.

Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@thehomebrewnerd thehomebrewnerd merged commit 12ad75a into main May 1, 2024
25 checks passed
@thehomebrewnerd thehomebrewnerd deleted the remove-dask-spark-support branch May 1, 2024 20:53
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Dask and Spark dataframes
2 participants