Fix for handling the G_IO_STATUS_ERROR #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denesb
added a commit
to denesb/xfce4-i3-workspaces-plugin
that referenced
this pull request
Jul 14, 2023
An old problem is that the plugin cannot work normally if the i3wm starts before xfce4-panel as in #62, here we're using a timer to handle the ipc resources' acquisition. May still have some segfault there. Tested in archlinux with latest xfce4-panel (v4.18.4). Investigating an error that causing the .xsession-errors during restart i3wm twice or more, crashed in g_io_channel_read_chars: and channel->is_readable. Backtrace seems indicates an error of i3ipc-glib. The problem is caused by an unhandled error status code from glib, submitted a PR to altdesktop/i3ipc-glib#41, but may not get merged due to unmaintained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Glib may returns G_IO_STATUS_ERROR without setting the
GError** error, making the i3ipc looping forever. This may happens in restarting i3wm multiple times.When the
G_IO_STATUS_ERRORreturned, continue the signal IPC shutdown process.