Replace autoloads for macro calls with static autoload definitions #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally delete autoloads for the definitions of the macros. Fixes alphapapa#13
|
Hi Anders, Thank you very much for fixing this issue that I neglected to take care of for so long. I appreciate your digging into the problem so thoroughly with your package-by-package testing. I didn't merge your commit directly, because I decided to make a long-overdue stable release before adding your fixes, so I rebased and committed it myself. @cruegge Chris, thanks also to you for reporting this bug, investigating it, and patiently waiting for it to be fixed. |
alphapapa
pushed a commit
that referenced
this pull request
Jan 15, 2018
Also delete autoloads for the macro definitions. This prevents helm-org-rifle from causing org to load unnecessarily. Fixes #13. Closes #20. Thanks to Anders Johansson (@andersjohansson) and Chris Ruegge (@cruegge).
|
Thanks!
That’s great
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally delete autoloads for the definitions of the macros.
Fixes #13
I stumbled upon this problem now when I noticed that org was loaded by
package-initialize. By removing every package and adding them one by one again to the elpa-dir and running(progn (package-initialize) (featurep 'org))I could find that helm-org-rifle caused the problem.This seems to fix the problem, as per the discussion in #13.