Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have focus outline appear outside of element rather than covering it. #259

Merged
merged 3 commits into from
Nov 11, 2016
Merged

Have focus outline appear outside of element rather than covering it. #259

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c955c5
Add 0 offset to focus outline to fix chrome bug
edwardhorsford Oct 26, 2016
3a97263
Inset focus for search inputs in header
edwardhorsford Nov 4, 2016
c958230
Make offset smaller to work around 1px border bug on inputs
edwardhorsford Nov 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions source/assets/stylesheets/_accessibility.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,19 @@ a:focus {
input:focus,
textarea:focus,
select:focus,
button:focus,
#global-header input:focus {
button:focus {
outline: 3px solid $focus-colour;
outline-offset: 0;
}

#global-header {

input[type=search]:focus {
outline: 3px solid $focus-colour;
/* Focus appears inside the input */
outline-offset: -3px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this -3px exposes a white line to the right. It’s technically correct, but given that this would require the refactoring of where search boxes live and how they’re styled across multiple services can we make it -2px for this PR? That normalises it across browsers in my (quick) testing. If you want to leave a comment do describing why that’s fine.

}

h1 a:focus {
background-color: transparent;
outline: none;
Expand Down