Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extended footer on certain pages #177

Merged
merged 2 commits into from
Aug 16, 2016
Merged

Fix extended footer on certain pages #177

merged 2 commits into from
Aug 16, 2016

Commits on May 3, 2016

  1. Fix extended footer on certain pages 

    Some pages (e.g. https://www.gov.uk/government/publications/armed-forces-corporate-covenant-signed-pledges) have a long revision history. This, by default, has a class of visuallyhidden that hides the extended content off screen using position:absolute and left:-9999em. While this is hidden, the viewport will extend itself to include absolutely positioned elements, even if they’re positioned horizontally off screen.

This patch clips off screen elements so that they don’t take up any vertical space. It doesn’t affect VoiceOver’s ability to read the extended content.
    Robin Whittleton committed May 3, 2016
    Configuration menu
    Copy the full SHA
    f5d5198 View commit details
    Browse the repository at this point in the history

  2. Update hiding code to match WebAIM 

    @accessiblewebuk pointed out that WebAIM have a recommended set of CSS for hiding offscreen: http://webaim.org/techniques/css/invisiblecontent/#absolutepositioning . This updates the class to match their height:1px / width:1px / top:auto recommendation.
    Robin Whittleton committed May 3, 2016
    Configuration menu
    Copy the full SHA
    012a7ff View commit details
    Browse the repository at this point in the history