show-hide-content should work with new radio/checkbox markup #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update the selectors in show-hide-content to work with both the new and original markup. Simply removing the `.block-label` left it feeling a bit unscoped, so I’ve added a direct child selector. This potentially could cause problems, but it works with our recommended markup old and new at least. - update the spec to follow the new markup. - update the documentation to recommend the new markup.
|
I'm keen to merge this as the examples of 'Conditionally revealing content' are currently broken for GOV.UK elements. Let's get this in and bump the toolkit, if there are suggestions for a better way of achieving this, we can roll those out later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.block-labelleft it feeling a bit unscoped, so I’ve added a direct child selector. This potentially could cause problems, but it works with our recommended markup old and new at least.Things to consider: