-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply black text colour to link-back on :focus #544
Conversation
@@ -201,10 +201,12 @@ p, | |||
&:link, | |||
&:visited, | |||
&:hover, | |||
a#{&}:focus, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it evaluates the parent selector (.link-back) and outputs it after the a tag resulting in a.link-back:focus which neutralizes the a:link:focus
set in govuk_template
introduced in sass 3.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is &:focus
not specific enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sad, specificity strikes again.
I've seen people double classes up too: '.link-back.link-back:focus'
Thanks for the extra info Jani 👍
What problem does the pull request solve?
Fixes issue #540 where
a:link:focus
in govuk_template applies text-link (blue) colour to this elementHow has this been tested?
Supported browsers
Screenshots (if appropriate):
What type of change is it?
Has the documentation been updated?