Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaaS improvements #375

Closed
wants to merge 3 commits into from
Closed

Conversation

tomskerous
Copy link

The PaaS team are conducting user research with the prototype kit.

We've found that the error message when basic auth hasn't been set isn't as helpful as it could be. We've not yet added a PaaS-specific error link, but hope to do that later once our own docs are ready for release. We would dearly like to test the new version of this error text with users in Newcastle next week.

We also found performance improvements by copying .gitignore to .cfignore - this prevented node.js dependencies being uploaded to PaaS by the user and then downloaded as part of the buildpack process on PaaS. Staging times were approximately halved for an unmodified prototyping kit as a result. This change should only affect Cloud Foundry users.

Stop Cloudfoundry duplicating dependency downloads.
User research has shown that designers are confused by this text. This
is a suggested improvement that we can
User research shows this wasn’t hugely helpful in practice.
@joelanman
Copy link
Contributor

Thanks for this! That error does look clearer.

When you say you'd like to test with users, do you mean you'd like this merged and released in order to do that?

@tomskerous
Copy link
Author

tomskerous commented Apr 19, 2017 via email

@joelanman
Copy link
Contributor

looks good, could you squash the last two commits together? They seem to iterate on the text, so I think we just need one. Also can you change the link URL to:

https://govuk-prototype-kit.herokuapp.com/docs/publishing-on-heroku#6-set-a-username-and-password

That's a bug that was there before your PR but we might as well fix it now

charlesrt pushed a commit to UKHomeOffice/home_office_design_kit that referenced this pull request Apr 24, 2017
# 5.1.1

- Update the alpha, beta and discovery colours to $govuk-blue to match
the updated phase banner ([PR
alphagov#370](alphagov/govuk_frontend_toolkit#370))
- Fix radio button show/hide behaviour when used outside a form ([PR
alphagov#375](alphagov/govuk_frontend_toolkit#375))
- Fix a "Stick at top when scrolling" component bug related to scroll
anchoring in Chrome 56+ ([PR
alphagov#376](alphagov/govuk_frontend_toolkit#376))
- Minor travis fixes ([PR
alphagov#373](alphagov/govuk_frontend_toolkit#373))

# 5.1.0

- Allow custom options when tracking events ([PR
alphagov#365](alphagov/govuk_frontend_toolkit#365))

# 5.0.3

- Change HMRC and DEFRA text colours for improved contrast ([PR
alphagov#368](alphagov/govuk_frontend_toolkit#368))
@tomskerous
Copy link
Author

Cancelling this as getting the merge to work is proving too fiddly. :-)
Now available, with the fix above, at #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants