Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Terraform and Concourse variables relating to EKS #398

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Add missing Terraform and Concourse variables relating to EKS #398

merged 2 commits into from
Aug 20, 2021

Conversation

karlbaker02
Copy link
Contributor

@karlbaker02 karlbaker02 commented Aug 20, 2021 •
edited by sengi
Loading

This PR adds:

  • missing Terraform variables to integration common.tfvars, for our EKS cluster.
  • a new Concourse eks.yaml variables file for EKS, to be able to deploy our EKS cluster in integration.

Trello card

Karl Baker added 2 commits August 20, 2021 14:17
Add missing Terraform variables to integration common.tfvars
4799ede 
This commit adds the variables `cluster_infrastructure_state_bucket` and `cluster_log_retention_in_days` to the integration `common.tfvars` Terraform variables file. By adding these variables we make our EKS cluster deployable to integration (in addition to making our config consistent between test and integration).
Add Concourse parameters for EKS
577ccce 
This commit adds a Concourse parameters file for the EKS-specific variables used in the `eks` Concourse pipeline.
sengi
sengi approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@sengi sengi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - good to keep the existing vars file in sync with the required vars that we've added recently (so we don't trip over this when we turn up in integration!)

@sengi
Copy link
Contributor

sengi commented Aug 20, 2021

I think it's fine to not tf plan this btw, since we've not deployed the EKS modules to integration at all yet. We're just being nice and keeping stuff in sync to avoid future problems since we already had a vars file for integration.

@karlbaker02
Copy link
Contributor Author

Thanks Chris 👍

@karlbaker02 karlbaker02 merged commit fafc98b into main Aug 20, 2021
@karlbaker02 karlbaker02 deleted the add-missing-variables-to-integration branch August 20, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sengi sengi sengi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlbaker02 @sengi