-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boilerplate template #731
Merged
Merged
Commits on May 31, 2018
-
Changes from [govuk_template](https://github.com/alphagov/govuk_template): Breaking changes: - Removed stylesheets relating to `govuk_template.css`, we now recommend people bundle stylesheets in their application. - Removed stylesheets relating to `print`, we do this at a component level. - Removed stylesheets relating to `font`, we now have a [new font loading strategy](#726) that does not require a different bundle. - Removed `ie8` specific class being added to the `html` element, since we don't require functionality - Remove `ie.js`, used to shim HTML5 files, add JSON2 support, we now recommend people bundle in their application. - Removed functionality to remove `js-enabled` class if `window.GOVUK` is not defined, at the moment we can't guarantee that this global will be set with GOV.UK Frontend. See alphagov/govuk_template#248 for details on this feature. Features: - Added a main block, now skip link works by default, this block can be overridden. Patch: - Moved Skip link into it's own block, calling the [Skip link component](https://github.com/alphagov/govuk-frontend/tree/master/src/components/skip-link) by default instead of being inlined. - Moved footer into it's own block, calling the [Footer component](https://github.com/alphagov/govuk-frontend/tree/master/src/components/footer) by default instead of being inlined. - Moved header into it's own block, calling the [Header component](https://github.com/alphagov/govuk-frontend/tree/master/src/components/header) by default instead of being inlined. - Changed the default `main` `id` to be `#main-content` to avoid being [styled by GOV.UK Elements](https://github.com/alphagov/govuk_elements/blob/8216538c1d2efb8b33372a22f28e1ea81d879ecd/assets/sass/elements/_layout.scss#L9).
Configuration menu - View commit details
-
Copy full SHA for ce755c7 - Browse repository at this point
Copy the full SHA ce755c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2631e23 - Browse repository at this point
Copy the full SHA 2631e23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72adc7f - Browse repository at this point
Copy the full SHA 72adc7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a11eb64 - Browse repository at this point
Copy the full SHA a11eb64View commit details -
Inspired by the GOV.UK Prototype Kit: https://govuk-prototype-kit.herokuapp.com/docs/examples/template-partial-areas We may want to move this into the GOV.UK Design System website.
Configuration menu - View commit details
-
Copy full SHA for cbd5f2a - Browse repository at this point
Copy the full SHA cbd5f2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 132c8f7 - Browse repository at this point
Copy the full SHA 132c8f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51f3028 - Browse repository at this point
Copy the full SHA 51f3028View commit details -
This is consistent with the original GOV.UK Template approach. - We need to reset default margins set by user-agents - We need to set background-colors
Configuration menu - View commit details
-
Copy full SHA for 5924ed5 - Browse repository at this point
Copy the full SHA 5924ed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6bb23a - Browse repository at this point
Copy the full SHA b6bb23aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cccb7d3 - Browse repository at this point
Copy the full SHA cccb7d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9331b5 - Browse repository at this point
Copy the full SHA c9331b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bb0f5d - Browse repository at this point
Copy the full SHA 4bb0f5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddf78a5 - Browse repository at this point
Copy the full SHA ddf78a5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.