Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Check behaviour of older Sass compilers with CSS custom properties #4926

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Apr 5, 2024

This PR fixes how the hsl call is made (as older versions of Sass, including Dart Sass v1.0.0, confuse it with Sass' own hsl function).

It also adds an update to GitHub actions storing the compiled result for each Sass version we test, so we can peek at what's being generated.

For the purposes of using CSS Custom Properties, looks like everything is in order:

  • custom properties starting with -- are present as expected in the output
  • so are the var() calls

Copy link

github-actions bot commented Apr 5, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.04 KiB
dist/govuk-frontend-development.min.js 42.21 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 87.2 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 81.94 KiB
packages/govuk-frontend/dist/govuk/all.mjs 4.17 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.03 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.2 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 77.67 KiB 40.18 KiB
accordion.mjs 22.71 KiB 12.85 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for ab3c4e5

@romaricpascal romaricpascal force-pushed the spike-css-custom-properties-old-sass branch from 4bc01b7 to cc8cec8 Compare April 5, 2024 15:35
@romaricpascal romaricpascal changed the title Fix older Sass versions confusing native hsl with Sass hsl [SPIKE] Check behaviour of older Sass compilers with CSS custom properties Apr 5, 2024
@romaricpascal romaricpascal force-pushed the spike-css-custom-properties-old-sass branch from cc8cec8 to ab3c4e5 Compare April 8, 2024 09:49
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4926 April 8, 2024 09:49 Inactive
@romaricpascal romaricpascal marked this pull request as ready for review April 8, 2024 09:49
@romaricpascal romaricpascal requested a review from a team as a code owner April 8, 2024 09:49
@romaricpascal romaricpascal merged commit f3cc890 into spike-css-custom-properties Apr 8, 2024
8 checks passed
@romaricpascal romaricpascal deleted the spike-css-custom-properties-old-sass branch April 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants