Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure govuk-font-size() handles string keys #4713

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Ensure govuk-font-size() handles string keys #4713

merged 4 commits into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. Ensure govuk-font-size() handles string keys 

    This lets us treat 14, “14”, “_14” and named “x-large” size keys equally
    @colinrotherham
    colinrotherham committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1ed26b0 View commit details
    Browse the repository at this point in the history

  2. Add new $size-internal-use-only for deprecated font sizes 

    Clearly explain why we’re flagging sizes that start with an underscore and what we’re going to do about it
    @colinrotherham
    colinrotherham committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    02f5803 View commit details
    Browse the repository at this point in the history

  3. Remove duplicate font declarations for point 14 

    We can remove the underscore in `_14` → `14` so the deprecated font declaration map continue to work without duplication
    @colinrotherham
    colinrotherham committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    220a4c0 View commit details
    Browse the repository at this point in the history

  4. Update changelog entry 

    Co-authored-by: Owen Jones <owen.jones@digital.cabinet-office.gov.uk>
    @colinrotherham @owenatgov
    colinrotherham and owenatgov committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ffbfd86 View commit details
    Browse the repository at this point in the history