Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG with a working workaroud for removal of govuk-if-ie8 #4559

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

romaricpascal
Copy link
Member

Mixins that accept content require @content, otherwise Sass fails to compile so the example need updating.

Release notes and PR content have already been updated.

Closes #4556

… mixin

Mixins that accept content require '@content', otherwise Sass fails
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4559 December 12, 2023 11:04 Inactive
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.72 KiB
dist/govuk-frontend-development.min.js 38.54 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.3 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.58 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.7 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.53 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 69.9 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.09 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 3.9 KiB
components/notification-banner/notification-banner.mjs 4.54 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.3 KiB
components/tabs/tabs.mjs 9.66 KiB

View stats and visualisations on the review app


Action run for 9fbc432

@36degrees 36degrees merged commit b44d7b0 into main Dec 13, 2023
46 checks passed
@36degrees 36degrees deleted the fix-missing-ie8-mixin-workaround branch December 13, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty govuk-if-ie8 mixin isn't valid Sass
4 participants