Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add html parameter to Exit this Page button #3878

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Add html parameter to Exit this Page button #3878

merged 1 commit into from
Jun 30, 2023

Conversation

querkmachine
Copy link
Member

@querkmachine querkmachine commented Jun 29, 2023 •
edited
Loading

In relation to #3688.

Changes

  • Adds a html parameter to the EtP component, to complement the existing text parameter. This is to allow service teams to provide their own copy containing visually-hidden text.
  • Updates tests and parameter documentation to align with these changes.

@querkmachine querkmachine requested review from dav-idc and a team June 29, 2023 17:38
@querkmachine querkmachine self-assigned this Jun 29, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3878 June 29, 2023 18:11 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3878 June 30, 2023 08:35 Inactive
@querkmachine querkmachine changed the title Update text, add html parameter to Exit this Page button Add html parameter to Exit this Page button Jun 30, 2023
@owenatgov owenatgov added this to the v4.7.0 milestone Jun 30, 2023
owenatgov
owenatgov reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could we please squash the commits? Whilst they more accurately reflect the history of the work at present, I think it might be simpler to reflect the change we're making at this point in time.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3878 June 30, 2023 10:31 Inactive
owenatgov
owenatgov approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@querkmachine
Copy link
Member Author

querkmachine commented Jun 30, 2023 •
edited
Loading

Have done so. The original version of the commit is here, for future reference around how I handled the default HTML and html & text parameter conflicts: a5983a0

@querkmachine querkmachine merged commit 2b4997c into support/4.x Jun 30, 2023
24 checks passed
@querkmachine querkmachine deleted the etp-button-html branch June 30, 2023 10:34
@owenatgov owenatgov mentioned this pull request Jul 11, 2023
Merged
@querkmachine querkmachine mentioned this pull request Jul 20, 2023
Merged
@colinrotherham colinrotherham mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenatgov owenatgov owenatgov approved these changes

@dav-idc dav-idc Awaiting requested review from dav-idc

Assignees

@querkmachine querkmachine

Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@querkmachine @owenatgov @govuk-design-system-ci